wip: check for all zeros on startup #2880
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
commented
Sep 11, 2024
accounts-db/src/accounts_db.rs
Outdated
| // this whole slot can likely be marked dead and dropped. Clean has to determine that. There could be an older non-zero account for any of these zero lamport accounts. | ||
| self.dirty_stores.insert(slot, Arc::clone(storage)); | ||
| self.accounts_index.add_uncleaned_roots([slot].into_iter()); | ||
| self.shrink_candidate_slots.lock().unwrap().insert(slot); |
There was a problem hiding this comment.
I don't know for sure we should do this. we may want to let clean calculate whether we can shrink or not. I suspect we don't want to add to shrink canddiate.
|
I restarted dev7 num_stored_slots_removed=16019i total_removed_storage_entries=16019i |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On startup, we can identify storages that have all zero lamport accounts. Perhaps the whole slot can be marked dead.
Summary of Changes
In generating index, we can find storages with all zeros and add them to clean.
Fixes #